Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broader sendmmsg() / recvmmsg() support #1231

Merged
merged 16 commits into from
Feb 18, 2019
Merged

Broader sendmmsg() / recvmmsg() support #1231

merged 16 commits into from
Feb 18, 2019

Conversation

dholroyd
Copy link
Contributor

As a prerequisite for getting sendmmsg() / recvmmsg() into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @gnzlbg (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@semarie
Copy link
Contributor

semarie commented Jan 27, 2019 via email

@dholroyd
Copy link
Contributor Author

Thanks @semarie; I've pushed 6f62973 to try and take that into account.

src/unix/bsd/netbsdlike/mod.rs Outdated Show resolved Hide resolved
src/unix/bsd/freebsdlike/mod.rs Outdated Show resolved Hide resolved
@dholroyd
Copy link
Contributor Author

aarch64-linux-android build timed out -- assume not related to these changes.

x86_64-unknown-freebsd failed with "Failed to start an instance! failed".

@dholroyd
Copy link
Contributor Author

Seems I broke asmjs-unknown-emscripten and wasm32-unknown-emscripten too; now fixed by 696d273 + 0d3a600 .

(I hope! Looks like CI still fails, but with the same errors as before any of these changes.)

@gnzlbg
Copy link
Contributor

gnzlbg commented Jan 28, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Jan 28, 2019

📌 Commit 0d3a600 has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Jan 28, 2019

⌛ Testing commit 0d3a600 with merge 006ec0c...

bors added a commit that referenced this pull request Jan 28, 2019
Broader sendmmsg() / recvmmsg() support

As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.
@bors
Copy link
Contributor

bors commented Jan 28, 2019

💔 Test failed - checks-cirrus

@gnzlbg
Copy link
Contributor

gnzlbg commented Jan 28, 2019

I've restarted the cirrus-ci build but it has been failing with:

Failed to start: UNKNOWN: ZONE_RESOURCE_POOL_EXHAUSTED_WITH_DETAILS The zone 'projects/cirrus-ci-community/zones/us-central1-f' does not have enough resources available to fulfill the request. '(resource type:pd-standard)'.

This sounds like a temporary issue, but i've opened an issue with cirrus upstream just in case: cirruslabs/cirrus-ci-docs#131

@gnzlbg
Copy link
Contributor

gnzlbg commented Jan 28, 2019

@bors: retry

bors added a commit that referenced this pull request Jan 28, 2019
Broader sendmmsg() / recvmmsg() support

As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.
@bors
Copy link
Contributor

bors commented Jan 28, 2019

⌛ Testing commit 0d3a600 with merge eb171ae...

@bors
Copy link
Contributor

bors commented Jan 28, 2019

💔 Test failed - checks-cirrus

@dholroyd
Copy link
Contributor Author

dholroyd commented Feb 3, 2019

Is cirrus better now? Worth a retry?

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 4, 2019

@bors: retry

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 4, 2019

cc @pietroalbani is @bors having some issues?

@bors
Copy link
Contributor

bors commented Feb 4, 2019

⌛ Testing commit 0d3a600 with merge 8ac9573...

bors added a commit that referenced this pull request Feb 4, 2019
Broader sendmmsg() / recvmmsg() support

As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.
@bors
Copy link
Contributor

bors commented Feb 4, 2019

💥 Test timed out

@bors
Copy link
Contributor

bors commented Feb 8, 2019

☔ The latest upstream changes (presumably #1247) made this pull request unmergeable. Please resolve the merge conflicts.

@dholroyd
Copy link
Contributor Author

dholroyd commented Feb 8, 2019

Rebased onto master to resolve merge conflicts.

Please retry 🙂

@dholroyd
Copy link
Contributor Author

The last set of build failures seemed to be unrelated to these changes.

If I have not understood the errors well, and there's something in there that I should address; please let me know!

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 16, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 16, 2019

📌 Commit d3c0eec has been approved by gnzlbg

@bors
Copy link
Contributor

bors commented Feb 16, 2019

⌛ Testing commit d3c0eec with merge 89f7e49...

bors added a commit that referenced this pull request Feb 16, 2019
Broader sendmmsg() / recvmmsg() support

As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.
@bors
Copy link
Contributor

bors commented Feb 16, 2019

💔 Test failed - checks-travis

@dholroyd
Copy link
Contributor Author

dholroyd commented Feb 17, 2019

https://travis-ci.com/rust-lang/libc/jobs/176489419 failed with,

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

https://travis-ci.com/rust-lang/libc/jobs/178288281 failed with,

$ rustup component add rustfmt-preview
error: component 'rustfmt' for target 'x86_64-unknown-linux-gnu' is unavailable for download

@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 18, 2019

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 18, 2019

⌛ Testing commit d3c0eec with merge 315e600...

bors added a commit that referenced this pull request Feb 18, 2019
Broader sendmmsg() / recvmmsg() support

As a prerequisite for getting `sendmmsg()` / `recvmmsg()` into nix ( nix-rust/nix#1017 ), support for non-linux platforms needs to be added in libc.

The initial commits in this PR will just be to test out target support via CI.
@bors
Copy link
Contributor

bors commented Feb 18, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 315e600 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants